r108641 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108640‎ | r108641 | r108642 >
Date:17:37, 11 January 2012
Author:daniel
Status:ok
Tags:
Comment:
apply lockdown to all actions on special pages (why not?\!)
Modified paths:
  • /trunk/extensions/Lockdown/Lockdown.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Lockdown/Lockdown.php
@@ -70,15 +70,10 @@
7171 $groups = null;
7272 $ns = $title->getNamespace();
7373 if ( NS_SPECIAL == $ns ) {
74 - if ( $action != 'read' ) {
75 - $result = false; #WTF? ignored, i guess...
76 - return true;
77 - } else {
78 - foreach ( $wgSpecialPageLockdown as $page => $g ) {
79 - if ( !$title->isSpecial( $page ) ) continue;
80 - $groups = $g;
81 - break;
82 - }
 74+ foreach ( $wgSpecialPageLockdown as $page => $g ) {
 75+ if ( !$title->isSpecial( $page ) ) continue;
 76+ $groups = $g;
 77+ break;
8378 }
8479 }
8580 else {

Status & tagging log