r108231 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108230‎ | r108231 | r108232 >
Date:14:17, 6 January 2012
Author:catrope
Status:resolved
Tags:
Comment:
Fix broken oldParser call in r108230
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.jqueryMsg.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.jqueryMsg.js
@@ -670,9 +670,10 @@
671671 // we'd have to cache the parser as a member of this.map, which sounds a bit ugly.
672672
673673 // Do not use mw.jqueryMsg unless required
 674+ var _this = this;
674675 if ( this.map.get( this.key ).indexOf( '{{' ) < 0 ) {
675676 // Fall back to mw.msg's simple parser
676 - return oldParser( this.key, this.parameters );
 677+ return oldParser.apply( _this );
677678 }
678679
679680 var messageFunction = mw.jqueryMsg.getMessageFunction( { 'messages': this.map } );

Follow-up revisions

RevisionCommit summaryAuthorDate
r108236Followup r108231, remove useless _thiscatrope15:14, 6 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108203Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER...santhosh09:14, 6 January 2012
r108230Fix up r108203: just loading mw.jqueryMsg in the bottom queue, then assuming ...catrope14:11, 6 January 2012

Status & tagging log