r108236 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108235‎ | r108236 | r108237 >
Date:15:14, 6 January 2012
Author:catrope
Status:ok
Tags:
Comment:
Followup r108231, remove useless _this
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.jqueryMsg.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.jqueryMsg.js
@@ -670,10 +670,9 @@
671671 // we'd have to cache the parser as a member of this.map, which sounds a bit ugly.
672672
673673 // Do not use mw.jqueryMsg unless required
674 - var _this = this;
675674 if ( this.map.get( this.key ).indexOf( '{{' ) < 0 ) {
676675 // Fall back to mw.msg's simple parser
677 - return oldParser.apply( _this );
 676+ return oldParser.apply( this );
678677 }
679678
680679 var messageFunction = mw.jqueryMsg.getMessageFunction( { 'messages': this.map } );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108230Fix up r108203: just loading mw.jqueryMsg in the bottom queue, then assuming ...catrope14:11, 6 January 2012
r108231Fix broken oldParser call in r108230catrope14:17, 6 January 2012

Status & tagging log