r108222 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r108221‎ | r108222 | r108223 >
Date:12:03, 6 January 2012
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Set position => 'top' for wikibits, required to support legacy gadgets. Spotted by Niklas on TranslateWiki. Ping r107327.
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/Resources.php
——@@ -864,7 +864,7 @@
865865 'scripts' => 'common/wikibits.js',
866866 'remoteBasePath' => $GLOBALS['wgStylePath'],
867867 'localBasePath' => $GLOBALS['wgStyleDirectory'],
868 - 'position' => 'bottom',
 868+ 'position' => 'top',
869869 ),
870870 'mediawiki.legacy.wikiprintable' => array(
871871 'styles' => array( 'common/wikiprintable.css' => array( 'media' => 'print' ) ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r108885[Core JS] Fix code from r107327 which was broken by r108222...krinkle00:40, 14 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107327[Core JS] wikibits.js / IEFixes clean up...krinkle16:12, 26 December 2011

Comments

#Comment by Krinkle (talk | contribs)   00:36, 14 January 2012

Afaik this is not needed. At least not for regression purposes. On several wikis gadgets were given [dependencies=mediawiki.legacy.wikibits] since the race condition was already happening (at least on Commons there were complaints).

I have no problem with conveniencing users with this, but since those gadgets were likely already breaking under some circumstances (slow connections, error in a module, any race condition or js error), we might keep it that way and require dependencies to be properly declared and shaving a little (wiki)bit from the top queue. Gain is minimal, but it's more a principle thing I guess.

Status & tagging log