r108885 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108884‎ | r108885 | r108886 >
Date:00:40, 14 January 2012
Author:krinkle
Status:ok
Tags:
Comment:
[Core JS] Fix code from r107327 which was broken by r108222
-- Of course one most not assume the DOM is finished enough for #p-logo to be parsed, simply bind to document ready
Modified paths:
  • /trunk/phase3/skins/common/IEFixes.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/IEFixes.js
@@ -63,10 +63,9 @@
6464 }
6565 };
6666
67 -if( isMSIE55 ) {
68 - // Legacy modules are loaded from the bottom
69 - // No need to wait for DOMContentReady or window.onload
70 - fixalpha();
 67+if ( isMSIE55 ) {
 68+ // ondomready
 69+ $( fixalpha );
7170 }
7271
7372 // fix ie6 disappering float bug

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107327[Core JS] wikibits.js / IEFixes clean up...krinkle16:12, 26 December 2011
r108222Set position => 'top' for wikibits, required to support legacy gadgets. Spott...catrope12:03, 6 January 2012

Status & tagging log