r108063 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108062‎ | r108063 | r108064 >
Date:18:51, 4 January 2012
Author:rsterbin
Status:ok
Tags:
Comment:
Brought in bottom impression tracking at 100% and init tracking at 1%
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -2029,6 +2029,10 @@
20302030 } );
20312031 // Keep track of links that must be removed after a successful submission
20322032 $.articleFeedbackv5.$toRemove = $( [] );
 2033+ // Track init at 1%
 2034+ if ( Math.random() * 100 < 1 ) {
 2035+ $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-init' );
 2036+ }
20332037 };
20342038
20352039 // }}}
@@ -2459,8 +2463,7 @@
24602464 if ( $.articleFeedbackv5.inDialog ) {
24612465 $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-impression-overlay' );
24622466 } else {
2463 - // Don't track bottom-of-the-page loads, at least for now
2464 - // $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-impression-bottom' );
 2467+ $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-impression-bottom' );
24652468 }
24662469
24672470 $.articleFeedbackv5.nowShowing = 'form';

Follow-up revisions

RevisionCommit summaryAuthorDate
r1080641.18wmf1: MFT r108063catrope18:57, 4 January 2012

Status & tagging log