r108064 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108063‎ | r108064 | r108065 >
Date:18:57, 4 January 2012
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: MFT r108063
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -2035,6 +2035,10 @@
20362036 } );
20372037 // Keep track of links that must be removed after a successful submission
20382038 $.articleFeedbackv5.$toRemove = $( [] );
 2039+ // Track init at 1%
 2040+ if ( Math.random() * 100 < 1 ) {
 2041+ $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-init' );
 2042+ }
20392043 };
20402044
20412045 // }}}
@@ -2465,8 +2469,7 @@
24662470 if ( $.articleFeedbackv5.inDialog ) {
24672471 $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-impression-overlay' );
24682472 } else {
2469 - // Don't track bottom-of-the-page loads, at least for now
2470 - // $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-impression-bottom' );
 2473+ $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-impression-bottom' );
24712474 }
24722475
24732476 $.articleFeedbackv5.nowShowing = 'form';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108063Brought in bottom impression tracking at 100% and init tracking at 1%rsterbin18:51, 4 January 2012

Status & tagging log