r107735 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107734‎ | r107735 | r107736 >
Date:20:35, 31 December 2011
Author:reedy
Status:resolved
Tags:
Comment:
bug 33014 and r107734

Add Tbps through Ybps (yay for code that just works (tm))
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
@@ -3810,7 +3810,7 @@
38113811 * @return string
38123812 */
38133813 function formatBitrate( $bps ) {
3814 - $units = array( 'bps', 'kbps', 'Mbps', 'Gbps' );
 3814+ $units = array( 'bps', 'kbps', 'Mbps', 'Gbps', 'Tbps', 'Pbps', 'Ebps', 'Zbps', 'Ypbs' );
38153815 if ( $bps <= 0 ) {
38163816 return $this->formatNum( $bps ) . $units[0];
38173817 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r107736Fail, fix Ypbs from r107735reedy20:36, 31 December 2011
r107751Fixup and add rest of tests...reedy22:30, 31 December 2011
r107752RELEASE-NOTES-1.19 to go with formatSize/formatBitrate work...reedy22:34, 31 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107733Followup r106791, r107692 and bug 33014...reedy20:20, 31 December 2011
r107734Start adding tests for Language::formatBitrate()...reedy20:30, 31 December 2011

Status & tagging log