r107751 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107750‎ | r107751 | r107752 >
Date:22:30, 31 December 2011
Author:reedy
Status:ok
Tags:
Comment:
Fixup and add rest of tests

Followup r107734

bug 33014 done too?
Modified paths:
  • /trunk/phase3/tests/phpunit/languages/LanguageTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/languages/LanguageTest.php
@@ -303,29 +303,48 @@
304304 array(
305305 0,
306306 "0bps",
307 - "0 bytes per second"
 307+ "0 bits per second"
308308 ),
309309 array(
310 - 1024,
 310+ 1000,
311311 "1kbps",
312 - "1 kilobyte per second"
 312+ "1 kilobit per second"
313313 ),
314314 array(
315 - 1024 * 1024,
 315+ 1000 * 1000,
316316 "1Mbps",
317 - "1 megabyte per second"
 317+ "1 megabit per second"
318318 ),
319 - // Test commented out as currently resulting in 1.1Gbps
320 -// array(
321 -// 1024 * 1024 * 1024,
322 -// "1Gbps",
323 -// "1 gigabyte per second"
324 -// ),
325 -// array(
326 -// 1024 * 1024 * 1024 * 1024,
327 -// "1,024Gbps",
328 -// "1,024 gigabytes per second"
329 -// ),
 319+ array(
 320+ pow( 10, 9 ),
 321+ "1Gbps",
 322+ "1 gigabit per second"
 323+ ),
 324+ array(
 325+ pow( 10, 12 ),
 326+ "1Tbps",
 327+ "1 terabit per second"
 328+ ),
 329+ array(
 330+ pow( 10, 15 ),
 331+ "1Pbps",
 332+ "1 petabit per second"
 333+ ),
 334+ array(
 335+ pow( 10, 18 ),
 336+ "1Ebps",
 337+ "1 exabit per second"
 338+ ),
 339+ array(
 340+ pow( 10, 21 ),
 341+ "1Zbps",
 342+ "1 zetabit per second"
 343+ ),
 344+ array(
 345+ pow( 10, 24 ),
 346+ "1Ybps",
 347+ "1 yottabit per second"
 348+ ),
330349 );
331350 }
332351 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r107752RELEASE-NOTES-1.19 to go with formatSize/formatBitrate work...reedy22:34, 31 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107733Followup r106791, r107692 and bug 33014...reedy20:20, 31 December 2011
r107734Start adding tests for Language::formatBitrate()...reedy20:30, 31 December 2011
r107735bug 33014 and r107734...reedy20:35, 31 December 2011

Status & tagging log