r107639 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107638‎ | r107639 | r107640 >
Date:18:03, 30 December 2011
Author:bsitu
Status:ok
Tags:
Comment:
followup to -r106223 - remove redundant message transformation and unused variables
Modified paths:
  • /trunk/extensions/MoodBar/include/MoodBarHTMLEmailNotification.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/include/MoodBarHTMLEmailNotification.php
@@ -138,8 +138,6 @@
139139 global $wgEnotifUseRealName, $wgRequest;
140140
141141 $this->composed_common = true;
142 -
143 - $keys = array();
144142
145143 if ( $this->editor->isAnon() ) {
146144 $pageEditor = wfMsgForContent( 'enotif_anon_editor', $this->editor->getName() );
@@ -151,7 +149,6 @@
152150 $this->subject = wfMessage( 'moodbar-enotif-subject' )->params( $pageEditor )->escaped();
153151
154152 // build the body
155 - $messageCache = MessageCache::singleton();
156153 $targetUserName = $this->targetUser->getName();
157154 $links = $this->buildEmailLink();
158155
@@ -162,7 +159,6 @@
163160 $this->response,
164161 $links['targetUserTalkPageUrl'],
165162 $pageEditor )->escaped();
166 - $textBody = MessageCache::singleton()->transform( $textBody, false, null, $this->title );
167163
168164 //html version, this is a little bit ugly as we have to make wiki link clickable in emails
169165 $action = $wgRequest->getVal( 'action' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106223follow up -r 105969 - update feedback response email with latest copybsitu18:50, 14 December 2011

Status & tagging log