r107640 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107639‎ | r107640 | r107641 >
Date:18:21, 30 December 2011
Author:krinkle
Status:ok
Tags:
Comment:
[mediawiki.debug] attempt at fixing off-screen mega wide cells for some queries.
* See also r107610 CR
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.debug.css (modified) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.debug.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.debug.css
@@ -19,6 +19,7 @@
2020 .mw-debug table {
2121 border-spacing: 0;
2222 width: 100%;
 23+ table-layout: fixed;
2324 }
2425
2526 .mw-debug table tr {
@@ -32,6 +33,7 @@
3334 .mw-debug table td {
3435 padding: 4px 10px;
3536 border-bottom: 1px solid #eee;
 37+ word-wrap: break-word;
3638 }
3739
3840 .mw-debug table td.nr {
Index: trunk/phase3/resources/mediawiki/mediawiki.debug.js
@@ -185,6 +185,12 @@
186186
187187 $table = $( '<table id="mw-debug-querylist"></table>' );
188188
 189+ // Widths on table cells and columns behave weird in some browsers like Chrome,
 190+ // in that, contrary to the W3 box model, padding does not increase cells having a fixed width
 191+ $('<colgroup>').css( 'width', /*padding=*/20 + ( String( this.data.queries.length ).length*/*fontSize*/11 ) ).appendTo( $table );
 192+ $('<colgroup>').appendTo( $table );
 193+ $('<colgroup>').css( 'width', 350 ).appendTo( $table );
 194+
189195 for ( i = 0, length = this.data.queries.length; i < length; i += 1 ) {
190196 query = this.data.queries[i];
191197
@@ -198,6 +204,7 @@
199205 .appendTo( $table );
200206 }
201207
 208+
202209 return $table;
203210 },
204211

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107610[mediawiki.debug] highlight current pane and styling...krinkle01:08, 30 December 2011

Status & tagging log