r107638 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107637‎ | r107638 | r107639 >
Date:17:45, 30 December 2011
Author:bsitu
Status:ok
Tags:
Comment:
followup to -r107617 - code style and consistency change
Modified paths:
  • /trunk/extensions/MoodBar/ApiFeedbackDashboardResponse.php (modified) (history)
  • /trunk/extensions/MoodBar/include/MoodBarHTMLEmailNotification.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/include/MoodBarHTMLEmailNotification.php
@@ -229,7 +229,9 @@
230230
231231 $to = new MailAddress( $user );
232232
233 - return UserMailer::send( $to, $this->from, $this->subject, $this->body, $this->replyto, $contentType = 'multipart/alternative; boundary=' . $this->mime_boundary );
 233+ return UserMailer::send( $to, $this->from, $this->subject,
 234+ $this->body, $this->replyto,
 235+ $contentType = 'multipart/alternative; boundary=' . $this->mime_boundary );
234236 }
235237
236238 /**
@@ -245,7 +247,7 @@
246248
247249 // if clickTracking is not enabled, return the full canonical url for email
248250 if ( !class_exists( 'ApiClickTracking' ) ) {
249 - foreach ( $pageObject AS $key => $value ) {
 251+ foreach ( $pageObject as $key => $value ) {
250252 $links[$key.'Url'] = $value->getCanonicalURL();
251253 }
252254 }
@@ -258,7 +260,7 @@
259261 $clickTrackingLink = $wgServer . $wgScriptPath . '/api.php?action=clicktracking&eventid=' .
260262 wfUrlencode( $eventid ) . '&token=' . wfUrlencode( $token );
261263
262 - foreach ( $pageObject AS $key => $value ) {
 264+ foreach ( $pageObject as $key => $value ) {
263265 $links[$key.'Url'] = $clickTrackingLink . '&redirectto=' . wfUrlencode( $value->getLinkURL() ) .
264266 '&namespacenumber=' . wfUrlencode( $value->getNamespace() );
265267 }
Index: trunk/extensions/MoodBar/ApiFeedbackDashboardResponse.php
@@ -67,7 +67,10 @@
6868 global $wgLang;
6969
7070 $EMailNotif = new MoodBarHTMLEmailNotification();
71 - $EMailNotif->notifyOnRespond( $wgUser, $talkPage, wfTimestampNow(), $item->getProperty('feedback'), $wgLang->truncate( $response, 250 ), $item->getProperty('feedbackitem')->getProperty( 'type' ) );
 71+ $EMailNotif->notifyOnRespond( $wgUser, $talkPage, wfTimestampNow(),
 72+ $item->getProperty('feedback'),
 73+ $wgLang->truncate( $response, 250 ),
 74+ $item->getProperty('feedbackitem')->getProperty( 'type' ) );
7275
7376 }
7477

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107617Adding ClickTracking to Feedback Response Email linksbsitu01:31, 30 December 2011

Status & tagging log