r107527 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107526‎ | r107527 | r107528 >
Date:20:53, 28 December 2011
Author:rmoen
Status:ok
Tags:
Comment:
follow up to r107526 due to code revert
Modified paths:
  • /trunk/extensions/MoodBar/ApiFeedbackDashboardResponse.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/ApiFeedbackDashboardResponse.php
@@ -52,9 +52,9 @@
5353 'title' => $talkPage->getFullText(),
5454 'appendtext' => ( $talkPage->exists() ? "\n\n" : '' ) .
5555 $feedback_link . "\n" .
56 - '<span id="feedback-dashboard-response-' . $item->getProperty('id') . '">&nbsp;</span>' . "\n\n" .
 56+ '<span id="feedback-dashboard-response-' . $id . '">&nbsp;</span>' . "\n\n" .
5757 $response . "\n\n~~~~\n\n" .
58 - '<span class="markashelpful-item" data-markashelpful-item="' . $item->getProperty('id') . '" data-markashelpful-type="mbresponse">&nbsp;</span>',
 58+ '<span class="markashelpful-item" data-markashelpful-item="' . $id . '" data-markashelpful-type="mbresponse">&nbsp;</span>',
5959 'token' => $params['token'],
6060 'summary' => $summary,
6161 'notminor' => true,

Sign-offs

UserFlagDate
Nikerabbitinspected06:33, 29 December 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r107529follow up to r107527 to pretty up the response elements a bitrmoen21:12, 28 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107526added nbsp to mark as helpful element & response element, parser was removing...rmoen20:48, 28 December 2011

Status & tagging log