r107529 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107528‎ | r107529 | r107530 >
Date:21:12, 28 December 2011
Author:rmoen
Status:ok
Tags:
Comment:
follow up to r107527 to pretty up the response elements a bit
Modified paths:
  • /trunk/extensions/MoodBar/ApiFeedbackDashboardResponse.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/ApiFeedbackDashboardResponse.php
@@ -52,7 +52,7 @@
5353 'title' => $talkPage->getFullText(),
5454 'appendtext' => ( $talkPage->exists() ? "\n\n" : '' ) .
5555 $feedback_link . "\n" .
56 - '<span id="feedback-dashboard-response-' . $id . '">&nbsp;</span>' . "\n\n" .
 56+ '<span id="feedback-dashboard-response-' . $id . '"></span>' . "\n\n" .
5757 $response . "\n\n~~~~\n\n" .
5858 '<span class="markashelpful-item" data-markashelpful-item="' . $id . '" data-markashelpful-type="mbresponse">&nbsp;</span>',
5959 'token' => $params['token'],

Sign-offs

UserFlagDate
Nikerabbitinspected06:35, 29 December 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r107540Rollback to reading item data in class name to prevent parser from removing h...rmoen22:47, 28 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107527follow up to r107526 due to code revertrmoen20:53, 28 December 2011

Status & tagging log