r107299 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r107298‎ \| r107299 \| r107300 >
Date:	23:09, 25 December 2011
Author:	siebrand
Status:	ok (Comments)
Tags:
Comment:	Bye, bye $wgExtensionAliasesFiles (deprecated in 1.16).
Modified paths:	/trunk/extensions/APC/APC.php (modified) (history) /trunk/extensions/AdminLinks/AdminLinks.php (modified) (history) /trunk/extensions/AdvancedRandom/AdvancedRandom.php (modified) (history) /trunk/extensions/AdvancedSearch/AdvancedSearch.php (modified) (history) /trunk/extensions/AjaxTest/AjaxTest.php (modified) (history) /trunk/extensions/ApiExplorer/SpecialApiExplorer.php (modified) (history) /trunk/extensions/ApiSandbox/ApiSandbox.php (modified) (history) /trunk/extensions/ApprovedRevs/ApprovedRevs.php (modified) (history) /trunk/extensions/ArticleFeedback/ArticleFeedback.php (modified) (history) /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php (modified) (history) /trunk/extensions/Asksql/Asksql.php (modified) (history) /trunk/extensions/BadImage/BadImage.php (modified) (history) /trunk/extensions/BlogPage/Blog.php (modified) (history) /trunk/extensions/BookManager/BookManager.php (modified) (history) /trunk/extensions/Call/Call.php (modified) (history) /trunk/extensions/CategoryIntersection/CategoryIntersection.php (modified) (history) /trunk/extensions/CategoryTree/CategoryTree.php (modified) (history) /trunk/extensions/Chemistry/SpecialChemicalsources.php (modified) (history) /trunk/extensions/CloseWikis/CloseWikis.php (modified) (history) /trunk/extensions/CollabWatchlist/CollabWatchlist.php (modified) (history) /trunk/extensions/Collection/Collection.php (modified) (history) /trunk/extensions/ConfirmEdit/ConfirmEdit.php (modified) (history) /trunk/extensions/ContactPageFundraiser/ContactPage.php (modified) (history) /trunk/extensions/ContributionReporting/ContributionReporting.php (modified) (history) /trunk/extensions/ContributionScores/ContributionScores.php (modified) (history) /trunk/extensions/ContributionTracking/ContributionTracking.php (modified) (history) /trunk/extensions/Contributors/Contributors.php (modified) (history) /trunk/extensions/CooperationStatistics/CooperationStatistics.php (modified) (history) /trunk/extensions/CountEdits/CountEdits.php (modified) (history) /trunk/extensions/CreateRedirect/CreateRedirect.php (modified) (history) /trunk/extensions/CrossNamespaceLinks/CrossNamespaceLinks.php (modified) (history) /trunk/extensions/DSMW/DSMW.php (modified) (history) /trunk/extensions/DataTransfer/DataTransfer.php (modified) (history) /trunk/extensions/DeleteBatch/DeleteBatch.php (modified) (history) /trunk/extensions/Deployment/Deployment.php (modified) (history) /trunk/extensions/Distribution/Distribution.php (modified) (history) /trunk/extensions/DonationInterface/donationinterface.php (modified) (history) /trunk/extensions/DonationInterface/donationinterface_langonly.php (modified) (history) /trunk/extensions/Drafts/Drafts.php (modified) (history) /trunk/extensions/Duplicator/Duplicator.php (modified) (history) /trunk/extensions/EmailCapture/EmailCapture.php (modified) (history) /trunk/extensions/EmailPage/EmailPage.php (modified) (history) /trunk/extensions/EmailUsers/EmailUsers.php (modified) (history) /trunk/extensions/EmergencyDeSysop/EmergencyDeSysop.php (modified) (history) /trunk/extensions/Entities/Entities.php (modified) (history) /trunk/extensions/ExpandTemplates/ExpandTemplates.php (modified) (history) /trunk/extensions/ExtensionManagement/ExtensionManagement.php (modified) (history) /trunk/extensions/ExternalPages/ExternalPages.php (modified) (history) /trunk/extensions/Farmer/Farmer.php (modified) (history) /trunk/extensions/FindSpam/FindSpam.php (modified) (history) /trunk/extensions/FlagPage/FlagPage.php (modified) (history) /trunk/extensions/Gadgets/Gadgets.php (modified) (history) /trunk/extensions/GetFamily/GetFamily.php (modified) (history) /trunk/extensions/GlobalBlocking/GlobalBlocking.php (modified) (history) /trunk/extensions/GlobalUserrights/GlobalUserrights.php (modified) (history) /trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap.php (modified) (history) /trunk/extensions/ImageTagging/ImageTagging.php (modified) (history) /trunk/extensions/ImportFreeImages/ImportFreeImages.php (modified) (history) /trunk/extensions/ImportUsers/ImportUsers.php (modified) (history) /trunk/extensions/IndexFunction/IndexFunction.php (modified) (history) /trunk/extensions/InspectCache/InspectCache.php (modified) (history) /trunk/extensions/Interwiki/Interwiki.php (modified) (history) /trunk/extensions/InterwikiList/InterwikiList.php (modified) (history) /trunk/extensions/LandingCheck/LandingCheck.php (modified) (history) /trunk/extensions/LastModified/LastModified.php (modified) (history) /trunk/extensions/LastUserLogin/LastUserLogin.php (modified) (history) /trunk/extensions/LinkFilter/Link.php (modified) (history) /trunk/extensions/LiquidThreads/LiquidThreads.php (modified) (history) /trunk/extensions/LiveTranslate/LiveTranslate.php (modified) (history) /trunk/extensions/LogEntry/LogEntry.php (modified) (history) /trunk/extensions/LookupUser/LookupUser.php (modified) (history) /trunk/extensions/Maintenance/Maintenance.php (modified) (history) /trunk/extensions/MassBlank/MassBlank.php (modified) (history) /trunk/extensions/MassEditRegex/MassEditRegex.php (modified) (history) /trunk/extensions/MetavidWiki/includes/MV_GlobalFunctions.php (modified) (history) /trunk/extensions/MostRevisors/MostRevisors.php (modified) (history) /trunk/extensions/MultiUpload/MultiUpload.php (modified) (history) /trunk/extensions/NewestPages/NewestPages.php (modified) (history) /trunk/extensions/NewsChannel/NewsChannel.php (modified) (history) /trunk/extensions/Notificator/Notificator.php (modified) (history) /trunk/extensions/NssMySQLAuth/NssMySQLAuth.php (modified) (history) /trunk/extensions/Nuke/Nuke.php (modified) (history) /trunk/extensions/Offline/Offline.php (modified) (history) /trunk/extensions/OpenID/OpenID.php (modified) (history) /trunk/extensions/OpenStackManager/OpenStackManager.php (modified) (history) /trunk/extensions/Oversight/HideRevision.php (modified) (history) /trunk/extensions/PackageForce/PackageForce.php (modified) (history) /trunk/extensions/PageTriage/PageTriage.php (modified) (history) /trunk/extensions/PasswordReset/PasswordReset.php (modified) (history) /trunk/extensions/Patroller/Patroller.php (modified) (history) /trunk/extensions/PictureGame/PictureGame.php (modified) (history) /trunk/extensions/Piwik/Piwik.php (modified) (history) /trunk/extensions/Player/Player.php (modified) (history) /trunk/extensions/Plotters/Plotters.php (modified) (history) /trunk/extensions/Poll/Poll.php (modified) (history) /trunk/extensions/PollNY/Poll.php (modified) (history) /trunk/extensions/PovWatch/PovWatch.php (modified) (history) /trunk/extensions/PrefStats/PrefStats.php (modified) (history) /trunk/extensions/PrefSwitch/PrefSwitch.php (modified) (history) /trunk/extensions/ProfileMonitor/ProfileMonitor.php (modified) (history) /trunk/extensions/ProofreadPage/ProofreadPage.php (modified) (history) /trunk/extensions/PureWikiDeletion/PureWikiDeletion.php (modified) (history) /trunk/extensions/PurgeCache/PurgeCache.php (modified) (history) /trunk/extensions/Push/Push.php (modified) (history) /trunk/extensions/QPoll/qp_user.php (modified) (history) /trunk/extensions/QuizGame/QuestionGame.php (modified) (history) /trunk/extensions/RDFIO/RDFIO.php (modified) (history) /trunk/extensions/RDFIO/specials/SpecialSPARQLEndpoint.php (modified) (history) /trunk/extensions/RandomInCategory/RandomInCategory.php (modified) (history) /trunk/extensions/ReaderFeedback/ReaderFeedback.php (modified) (history) /trunk/extensions/RecordAdmin/RecordAdmin.php (modified) (history) /trunk/extensions/RefHelper/RefHelper.php (modified) (history) /trunk/extensions/RefreshSpecial/RefreshSpecial.php (modified) (history) /trunk/extensions/ReplaceText/ReplaceText.php (modified) (history) /trunk/extensions/ResearchTools/ResearchTools.php (modified) (history) /trunk/extensions/ResourceLoaderTests/ResourceLoaderTests.php (modified) (history) /trunk/extensions/SecurePoll/SecurePoll.php (modified) (history) /trunk/extensions/SelectionSifter/SelectionSifter.php (modified) (history) /trunk/extensions/SemanticDrilldown/SemanticDrilldown.php (modified) (history) /trunk/extensions/SemanticForms/SemanticForms.php (modified) (history) /trunk/extensions/SemanticMediaWiki/includes/SMW_Setup.php (modified) (history) /trunk/extensions/SemanticProjectManagement/SemanticProjectManagement.php (modified) (history) /trunk/extensions/SemanticSignup/SemanticSignup.php (modified) (history) /trunk/extensions/SemanticWatchlist/SemanticWatchlist.php (modified) (history) /trunk/extensions/SemanticWebBrowser/SemanticWebBrowser.php (modified) (history) /trunk/extensions/SharedUserRights/SharedUserRights.php (modified) (history) /trunk/extensions/ShortUrl/ShortUrl.php (modified) (history) /trunk/extensions/ShowProcesslist/ShowProcesslist.php (modified) (history) /trunk/extensions/SignDocument/SignDocument.php (modified) (history) /trunk/extensions/SiteMatrix/SiteMatrix.php (modified) (history) /trunk/extensions/SocialProfile/SocialProfile.php (modified) (history) /trunk/extensions/SpamDiffTool/SpamDiffTool.php (modified) (history) /trunk/extensions/SpamRegex/SpamRegex.php (modified) (history) /trunk/extensions/Special404/Special404.php (modified) (history) /trunk/extensions/SportsTeams/SportsTeams.php (modified) (history) /trunk/extensions/StalePages/StalePages.php (modified) (history) /trunk/extensions/Storyboard/Storyboard.php (modified) (history) /trunk/extensions/StyleGuideDemo/StyleGuideDemo.php (modified) (history) /trunk/extensions/Sudo/Sudo.php (modified) (history) /trunk/extensions/TemplateLink/TemplateLink.setup.php (modified) (history) /trunk/extensions/ThemeDesigner/ThemeDesigner.php (modified) (history) /trunk/extensions/TodoTasks/TodoTasks.php (modified) (history) /trunk/extensions/TradeTrack/TradeTrack.php (modified) (history) /trunk/extensions/Translate/Translate.php (modified) (history) /trunk/extensions/UnicodeConverter/UnicodeConverter.php (modified) (history) /trunk/extensions/UploadWizard/UploadWizard.php (modified) (history) /trunk/extensions/UsageStatistics/UsageStatistics.php (modified) (history) /trunk/extensions/UserDebugInfo/UserDebugInfo.php (modified) (history) /trunk/extensions/UserMerge/UserMerge.php (modified) (history) /trunk/extensions/UserOptionStats/UserOptionStats.php (modified) (history) /trunk/extensions/UserStatus/UserStatus.php (modified) (history) /trunk/extensions/VariablePage/VariablePage.php (modified) (history) /trunk/extensions/Video/Video.php (modified) (history) /trunk/extensions/VipsScaler/VipsTest.php (modified) (history) /trunk/extensions/Vote/Vote.php (modified) (history) /trunk/extensions/WatchSubpages/WatchSubpages.php (modified) (history) /trunk/extensions/Watchers/Watchers.php (modified) (history) /trunk/extensions/WebChat/WebChat.php (modified) (history) /trunk/extensions/WhatIsMyIP/WhatIsMyIP.php (modified) (history) /trunk/extensions/WhiteListEdit/WhiteListEdit.php (modified) (history) /trunk/extensions/WhoIsWatching/WhoIsWatching.php (modified) (history) /trunk/extensions/WhosOnline/WhosOnline.php (modified) (history) /trunk/extensions/WikiAtHome/WikiAtHome.php (modified) (history) /trunk/extensions/WikiBhasha/WikiBhasha.php (modified) (history) /trunk/extensions/WikiForum/WikiForum.php (modified) (history) /trunk/extensions/WikiSync/WikiSync.php (modified) (history) /trunk/extensions/Wikimania/Wikimania.php (modified) (history) /trunk/extensions/WikimediaIncubator/WikimediaIncubator.php (modified) (history) /trunk/extensions/examples/FourFileTemplate/MyExtension.php (modified) (history) /trunk/extensions/gis/geo.php (modified) (history) /trunk/extensions/uniwiki/CreatePage/CreatePage.php (modified) (history) /trunk/extensions/wikihiero/wikihiero.php (modified) (history) /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history) /trunk/phase3/includes/DefaultSettings.php (modified) (history) /trunk/phase3/includes/LocalisationCache.php (modified) (history) /trunk/phase3/maintenance/mergeMessageFileList.php (modified) (history)

Follow-up revisions

Revision	Commit summary	Author	Date
r107504	Follow-up to r107299 - better location for $wgExtensionMessagesFiles line	yaron	16:18, 28 December 2011
r112245	New DataValidator class, and donationinterface.php Only: MFT r107299, r10755...	khorn	21:42, 23 February 2012
r112287	MFT r101785, r105938, r105941, r105953, r106109, r106158, r106259, r106366, r...	khorn	01:29, 24 February 2012

Comments

#Comment by Reedy (talk | contribs) 23:21, 25 December 2011

Wheeee

#Comment by Jeroen De Dauw (talk | contribs) 23:54, 25 December 2011

You broke compatibility with 1.15!!! :<0 Please revert ASAP!

Ok, sorry, this is me not being serious, I have no problems w/ this commit (already dropped 1.15 compat anyway).

Status & tagging log

21:00, 26 December 2011 Aaron Schulz (talk | contribs) changed the status of r107299 [removed: new added: ok]