r107041 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r107040
|
r107041
|
r107042
>
Date:
04:23, 22 December 2011
Author:
laner
Status:
ok
Tags:
Comment:
Send ip for release as an associative array, rather than as a string. Resolves
bug 33313
.
Modified paths:
/trunk/extensions/OpenStackManager/OpenStackNovaController.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/OpenStackManager/OpenStackNovaController.php
—
—
@@ -507,7 +507,7 @@
508
508
* @return
509
509
*/
510
510
function releaseAddress( $ip ) {
511
- $response = $this->novaConnection->release_address( $ip );
511
+ $response = $this->novaConnection->release_address( array( 'PublicIp' => $ip ) );
512
512
513
513
return $response->isOK();
514
514
}
Sign-offs
User
Flag
Date
Nikerabbit
inspected
14:02, 23 December 2011
Status & tagging log
09:01, 18 January 2012
Siebrand
(
talk
|
contribs
)
changed the
tags
for r107041
[
removed:
openstack]
16:22, 24 December 2011
Reedy
(
talk
|
contribs
)
changed the
status
of r107041
[
removed:
new
added:
ok]
03:12, 23 December 2011
RobLa-WMF
(
talk
|
contribs
)
changed the
tags
for r107041
[
added:
openstack]