r107004 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r107003‎ \| r107004 \| r107005 >
Date:	23:02, 21 December 2011
Author:	pgehres
Status:	ok (Comments)
Tags:
Comment:	Adding missing </ul> to the rcc forms. Oops. FU r106968
Modified paths:	/trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vm.html (modified) (history) /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vma.html (modified) (history) /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vmad.html (modified) (history) /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vmaj.html (modified) (history) /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vmd.html (modified) (history) /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vmj.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vmad.html
—	—	@@ -49,7 +49,8 @@
50	50	<li><input id="cc-amex" name="cardtype" type="radio" value="american" class="cardradio" /> <label for="cc-amex"><img alt="American Express" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-amex.png" /></label></li>
51	51	<li><input id="cc-discover" name="cardtype" type="radio" value="discover" class="cardradio" /> <label for="cc-discover"><img alt="Discover" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-discover.png" /></label></li>
52	52	<!--<li><input id="cc-jcb" name="cardtype" type="radio" value="jcb" class="cardradio" /> <label for="cc-jcb"><img alt="JCB" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-jcb.png" /></label></li>-->
53		- <div id="paymentContinue" style="margin-top: 10px; display: none;"> <input class="btn" id="paymentContinueBtn" type="button" value="%donate_interface-continue%" /></div>
	53	+ </ul>
	54	+ <div id="paymentContinue" style="margin-top: 10px; display: none;"> <input class="btn" id="paymentContinueBtn" type="button" value="%donate_interface-continue%" /></div>
54	55	</dd>
55	56	</dl>
56	57	</td>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vmj.html
—	—	@@ -49,6 +49,7 @@
50	50	<!--<li><input id="cc-amex" name="cardtype" type="radio" value="american" class="cardradio" /> <label for="cc-amex"><img alt="American Express" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-amex.png" /></label></li>-->
51	51	<!--<li><input id="cc-discover" name="cardtype" type="radio" value="discover" class="cardradio" /> <label for="cc-discover"><img alt="Discover" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-discover.png" /></label></li>-->
52	52	<li><input id="cc-jcb" name="cardtype" type="radio" value="jcb" class="cardradio" /> <label for="cc-jcb"><img alt="JCB" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-jcb.png" /></label></li>
	53	+ </ul>
53	54	<div id="paymentContinue" style="margin-top: 10px; display: none;"> <input class="btn" id="paymentContinueBtn" type="button" value="%donate_interface-continue%" /></div>
54	55	</dd>
55	56	</dl>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vmaj.html
—	—	@@ -49,6 +49,7 @@
50	50	<li><input id="cc-amex" name="cardtype" type="radio" value="american" class="cardradio" /> <label for="cc-amex"><img alt="American Express" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-amex.png" /></label></li>
51	51	<!--<li><input id="cc-discover" name="cardtype" type="radio" value="discover" class="cardradio" /> <label for="cc-discover"><img alt="Discover" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-discover.png" /></label></li>-->
52	52	<li><input id="cc-jcb" name="cardtype" type="radio" value="jcb" class="cardradio" /> <label for="cc-jcb"><img alt="JCB" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-jcb.png" /></label></li>
	53	+ </ul>
53	54	<div id="paymentContinue" style="margin-top: 10px; display: none;"> <input class="btn" id="paymentContinueBtn" type="button" value="%donate_interface-continue%" /></div>
54	55	</dd>
55	56	</dl>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vm.html
—	—	@@ -49,6 +49,7 @@
50	50	<!--<li><input id="cc-amex" name="cardtype" type="radio" value="american" class="cardradio" /> <label for="cc-amex"><img alt="American Express" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-amex.png" /></label></li>-->
51	51	<!--<li><input id="cc-discover" name="cardtype" type="radio" value="discover" class="cardradio" /> <label for="cc-discover"><img alt="Discover" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-discover.png" /></label></li>-->
52	52	<!--<li><input id="cc-jcb" name="cardtype" type="radio" value="jcb" class="cardradio" /> <label for="cc-jcb"><img alt="JCB" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-jcb.png" /></label></li>-->
	53	+ </ul>
53	54	<div id="paymentContinue" style="margin-top: 10px; display: none;"> <input class="btn" id="paymentContinueBtn" type="button" value="%donate_interface-continue%" /></div>
54	55	</dd>
55	56	</dl>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vma.html
—	—	@@ -49,6 +49,7 @@
50	50	<li><input id="cc-amex" name="cardtype" type="radio" value="american" class="cardradio" /> <label for="cc-amex"><img alt="American Express" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-amex.png" /></label></li>
51	51	<!--<li><input id="cc-discover" name="cardtype" type="radio" value="discover" class="cardradio" /> <label for="cc-discover"><img alt="Discover" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-discover.png" /></label></li>-->
52	52	<!--<li><input id="cc-jcb" name="cardtype" type="radio" value="jcb" class="cardradio" /> <label for="cc-jcb"><img alt="JCB" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-jcb.png" /></label></li>-->
	53	+ </ul>
53	54	<div id="paymentContinue" style="margin-top: 10px; display: none;"> <input class="btn" id="paymentContinueBtn" type="button" value="%donate_interface-continue%" /></div>
54	55	</dd>
55	56	</dl>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/rcc/rcc-vmd.html
—	—	@@ -49,6 +49,7 @@
50	50	<!--<li><input id="cc-amex" name="cardtype" type="radio" value="american" class="cardradio" /> <label for="cc-amex"><img alt="American Express" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-amex.png" /></label></li>-->
51	51	<li><input id="cc-discover" name="cardtype" type="radio" value="discover" class="cardradio" /> <label for="cc-discover"><img alt="Discover" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-discover.png" /></label></li>
52	52	<!--<li><input id="cc-jcb" name="cardtype" type="radio" value="jcb" class="cardradio" /> <label for="cc-jcb"><img alt="JCB" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-jcb.png" /></label></li>-->
	53	+ </ul>
53	54	<div id="paymentContinue" style="margin-top: 10px; display: none;"> <input class="btn" id="paymentContinueBtn" type="button" value="%donate_interface-continue%" /></div>
54	55	</dd>
55	56	</dl>

Follow-up revisions

Revision	Commit summary	Author	Date
r107009	MFT r106136, r106968, r106970, r106979, r106994, r106996, r106998, r106999, ...	khorn	23:45, 21 December 2011

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r106968	Adding base recurring forms. Removing old test forms for recurring.	pgehres	19:23, 21 December 2011

Comments

#Comment by Khorn (WMF) (talk | contribs) 23:08, 21 December 2011

Note: The spacing looks weird in CR, because this was apparently cloned from something that used spaces instead of tabs. We should stop doing that. ;)

Status & tagging log

23:08, 21 December 2011 Khorn (WMF) (talk | contribs) changed the status of r107004 [removed: new added: ok]