r106789 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106788‎ | r106789 | r106790 >
Date:12:49, 20 December 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Split Special:PageTranslation styles into different module
Modified paths:
  • /trunk/extensions/Translate/Translate.php (modified) (history)
  • /trunk/extensions/Translate/resources/ext.translate.css (modified) (history)
  • /trunk/extensions/Translate/resources/ext.translate.special.pagetranslation.css (added) (history)
  • /trunk/extensions/Translate/tag/SpecialPageTranslation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/SpecialPageTranslation.php
@@ -366,7 +366,7 @@
367367 global $wgOut, $wgContLang;
368368
369369 $wgOut->setSubtitle( $this->user->getSkin()->link( $page->getTitle() ) );
370 - $wgOut->addModules( 'ext.translate' );
 370+ $wgOut->addModules( 'ext.translate.special.pagetranslation' );
371371
372372 $wgOut->addWikiMsg( 'tpt-showpage-intro' );
373373
Index: trunk/extensions/Translate/Translate.php
@@ -211,6 +211,11 @@
212212 'styles' => 'resources/ext.translate.special.supportedlanguages.css',
213213 ) + $resourcePaths;
214214
 215+$wgResourceModules['ext.translate.special.pagetranslation'] = array(
 216+ 'styles' => 'resources/ext.translate.special.pagetranslation.css',
 217+ 'position' => 'top',
 218+) + $resourcePaths;
 219+
215220 $wgResourceModules['ext.translate.special.importtranslations'] = array(
216221 'scripts' => 'resources/ext.translate.special.importtranslations.js',
217222 'dependencies' => array(
Index: trunk/extensions/Translate/resources/ext.translate.css
@@ -34,17 +34,6 @@
3535 padding: 0.5em;
3636 }
3737
38 -.mw-tpt-sp-legend {
39 - font-weight: bold;
40 -}
41 -
42 -.mw-tpt-sp-content {
43 - font-size: small;
44 - padding-left: 2em;
45 - padding-right: 2em;
46 - padding-bottom: 2ex;
47 -}
48 -
4938 /* First Steps '*/
5039 #translate-fs-signup {
5140 display: block;
@@ -59,4 +48,4 @@
6049 -moz-border-radius: 10px;
6150 -webkit-border-radius: 10px;
6251 background-color: #D1E231 !important;
63 -}
\ No newline at end of file
 52+}
Index: trunk/extensions/Translate/resources/ext.translate.special.pagetranslation.css
@@ -0,0 +1,18 @@
 2+.mw-tpt-sp-section {
 3+ padding-bottom: 3ex;
 4+}
 5+
 6+.mw-tpt-sp-section-type-old {
 7+ opacity: 0.65;
 8+}
 9+
 10+.mw-tpt-sp-legend {
 11+ font-weight: bold;
 12+ font-size: 110%;
 13+}
 14+
 15+.mw-tpt-sp-content {
 16+ font-size: small;
 17+ padding-left: 2em;
 18+ padding-right: 2em;
 19+}
Property changes on: trunk/extensions/Translate/resources/ext.translate.special.pagetranslation.css
___________________________________________________________________
Added: svn:eol-style
120 + native

Comments

#Comment by Santhosh.thottingal (talk | contribs)   11:44, 21 December 2011

+ padding-bottom: 3ex;

Is there a reason for using ex instead of em?

#Comment by Nikerabbit (talk | contribs)   11:55, 21 December 2011

Well, one ex is supposed to be height of x. But I just used something that achieves the desired visual result.

#Comment by Nikerabbit (talk | contribs)   12:02, 21 December 2011

Status & tagging log