r106788 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106787‎ | r106788 | r106789 >
Date:12:46, 20 December 2011
Author:reedy
Status:ok
Tags:
Comment:
Don't manually replace ' ' with '_', use User::getTitleKey
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuthHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuthHooks.php
@@ -765,7 +765,7 @@
766766 $params['domain'] = $parts[2];
767767 }
768768 $params['properties']['ca-local-url'] = $params['url'];
769 - $params['url'] = $wiki->getUrl( 'User:' . str_replace( ' ', '_', $user->getName() ) );
 769+ $params['url'] = $wiki->getUrl( 'User:' . $user->getTitleKey() );
770770 return true;
771771 }
772772 }

Status & tagging log