r106454 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106453‎ | r106454 | r106455 >
Date:18:17, 16 December 2011
Author:jeroendedauw
Status:reverted (Comments)
Tags:lamecommitsummary 
Comment:
follow up to r106094
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -97,8 +97,10 @@
9898 unset( $nav[$section][$key]['class'] );
9999 }
100100 if ( isset( $link['tooltiponly'] ) && $link['tooltiponly'] ) {
101 - $nav[$section][$key]['key'] =
102 - Linker::titleAttrib( $xmlID );
 101+ $tooltip = Linker::titleAttrib( $xmlID );
 102+ $tooltip = $tooltip === false ? '' : Xml::expandAttributes( array( 'title' => $tooltip ) );
 103+ $nav[$section][$key]['key'] = $tooltip;
 104+
103105 } else {
104106 $nav[$section][$key]['key'] =
105107 Xml::expandAttributes( Linker::tooltipAndAccesskeyAttribs( $xmlID ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r106875Revert r106094 (broken unnecessary cleanup), r106454 (ugly unneceessary cleanup)...brion21:57, 20 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106094fix depracted method usagejeroendedauw21:16, 13 December 2011

Comments

#Comment by Siebrand (talk | contribs)   19:25, 16 December 2011

If you follow up another revision, can you please also mention what you are addressing to not make it a puzzle? Tia

Status & tagging log