r106875 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106874‎ | r106875 | r106876 >
Date:21:57, 20 December 2011
Author:brion
Status:ok
Tags:
Comment:
Revert r106094 (broken unnecessary cleanup), r106454 (ugly unneceessary cleanup)

The ugliness of this sort of code is probably part of why there's still a Linker::tooltip() function.
Please don't just replace it with worse code; if truly cleaning it up this should be done by giving a saner interface to the nav generation code
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
——@@ -97,10 +97,8 @@
9898 unset( $nav[$section][$key]['class'] );
9999 }
100100 if ( isset( $link['tooltiponly'] ) && $link['tooltiponly'] ) {
101 - $tooltip = Linker::titleAttrib( $xmlID );
102 - $tooltip = $tooltip === false ? '' : Xml::expandAttributes( array( 'title' => $tooltip ) );
103 - $nav[$section][$key]['key'] = $tooltip;
104 -
 101+ $nav[$section][$key]['key'] =
 102+ Linker::tooltip( $xmlID );
105103 } else {
106104 $nav[$section][$key]['key'] =
107105 Xml::expandAttributes( Linker::tooltipAndAccesskeyAttribs( $xmlID ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106094fix depracted method usagejeroendedauw21:16, 13 December 2011
r106454follow up to r106094jeroendedauw18:17, 16 December 2011

Status & tagging log