r106425 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106424‎ | r106425 | r106426 >
Date:11:34, 16 December 2011
Author:santhosh
Status:ok (Comments)
Tags:
Comment:
Reverting 106316, It prevents some click events get fired on menu.
Modified paths:
  • /trunk/extensions/Narayam/resources/ext.narayam.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/resources/ext.narayam.core.js
@@ -660,6 +660,7 @@
661661 var positionFunction = rtlEnv ? "append" : "prepend";
662662 $( '#p-personal ul:first' )[positionFunction]( $li );
663663 $( 'body' ).prepend( $menu );
 664+ $menu.hide();
664665 $li.click( function( event ) {
665666 var menuSide, menuOffset, distanceToEdge;
666667
@@ -699,9 +700,7 @@
700701 $menu.removeClass( 'open' );
701702 $menu.hide();
702703 } );
703 - $menu.click( function( event ) {
704 - event.stopPropagation();
705 - } );
 704+
706705 // Workaround for IE bug - activex components like input fields
707706 // coming on top of everything.
708707 // TODO: is there a better solution other than hiding it on hover?

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106316Remove the unnesessary hide(), It will be hidden using css....santhosh11:23, 15 December 2011

Comments

#Comment by Reedy (talk | contribs)   13:01, 16 December 2011

Use r106316 to mark it as a followup to another revision

Status & tagging log