r106316 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106315‎ | r106316 | r106317 >
Date:11:23, 15 December 2011
Author:santhosh
Status:reverted
Tags:
Comment:
Remove the unnesessary hide(), It will be hidden using css.
Do not hide menu when clicked on the menu items.
Modified paths:
  • /trunk/extensions/Narayam/resources/ext.narayam.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/resources/ext.narayam.core.js
@@ -660,7 +660,6 @@
661661 var positionFunction = rtlEnv ? "append" : "prepend";
662662 $( '#p-personal ul:first' )[positionFunction]( $li );
663663 $( 'body' ).prepend( $menu );
664 - $menu.hide();
665664 $li.click( function( event ) {
666665 var menuSide, menuOffset, distanceToEdge;
667666
@@ -700,7 +699,9 @@
701700 $menu.removeClass( 'open' );
702701 $menu.hide();
703702 } );
704 -
 703+ $menu.click( function( event ) {
 704+ event.stopPropagation();
 705+ } );
705706 // Workaround for IE bug - activex components like input fields
706707 // coming on top of everything.
707708 // TODO: is there a better solution other than hiding it on hover?

Follow-up revisions

RevisionCommit summaryAuthorDate
r106425Reverting 106316, It prevents some click events get fired on menu.santhosh11:34, 16 December 2011

Status & tagging log