r106348 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106347‎ | r106348 | r106349 >
Date:18:19, 15 December 2011
Author:bsitu
Status:resolved
Tags:
Comment:
follow up to r105635 - use "!" instead of "== false" in condition checking for code consistency
Modified paths:
  • /trunk/extensions/MoodBar/ApiMoodBarSetUserEmail.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/ApiMoodBarSetUserEmail.php
@@ -45,7 +45,7 @@
4646
4747 case 'resendverification':
4848 //only sends the email if the email has not been verified
49 - if ( $wgUser->getEmail() && $wgUser->isEmailConfirmed() == false ) {
 49+ if ( $wgUser->getEmail() && !$wgUser->isEmailConfirmed() ) {
5050 $status = $wgUser->sendConfirmationMail( 'set' );
5151 if ( !$status->isGood() ) {
5252 $error = $status->getWikiText( 'mailerror' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r106359sends out email confirmation only if email and email authentication are enabled!bsitu19:27, 15 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105635Send out email verification only if the user has email and the email has not ...bsitu01:40, 9 December 2011

Status & tagging log