r106347 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106346‎ | r106347 | r106348 >
Date:18:19, 15 December 2011
Author:khorn
Status:ok
Tags:
Comment:
followup r100954, r101060, r101554
TwoStepAmount should not be loaded in donationinterface.php.
Modified paths:
  • /trunk/extensions/DonationInterface/donationinterface.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/donationinterface.php
@@ -118,19 +118,8 @@
119119 $wgAutoloadClasses['GlobalCollectGateway'] = $donationinterface_dir . 'globalcollect_gateway/globalcollect_gateway.body.php';
120120 $wgAutoloadClasses['GlobalCollectGatewayResult'] = $donationinterface_dir . 'globalcollect_gateway/globalcollect_resultswitcher.body.php';
121121 $wgAutoloadClasses['GlobalCollectAdapter'] = $donationinterface_dir . 'globalcollect_gateway/globalcollect.adapter.php';
122 -
123 - $wgAutoloadClasses['Gateway_Form_TwoStepAmount'] = $donationinterface_dir . 'globalcollect_gateway/forms/TwoStepAmount.php';
124 -
125 - $wgResourceModules[ 'gc.form.core.validate' ] = array(
126 - // scripts are not being picked up properly. These are currently only being loaded in TwoStepAmount.php
127 - 'scripts' => array( 'js/validate.js', 'js/jquery.validate.js', 'js/jquery.validate.additional-methods.js', ),
128 - 'dependencies' => array( 'ext.donationInterface.errorMessages', 'jquery.ui.accordion', ),
129 - 'localBasePath' => $donationinterface_dir . 'globalcollect_gateway/modules',
130 - 'remoteExtPath' => 'DonationInterface/globalcollect_gateway/modules',
131 - 'styles' => 'css/style.css',
132 - );
133 -
134122 }
 123+
135124 //PayflowPro gateway classes
136125 if ( $optionalParts['PayflowPro'] === true ){
137126 $wgAutoloadClasses['PayflowProGateway'] = $donationinterface_dir . 'payflowpro_gateway/payflowpro_gateway.body.php';

Follow-up revisions

RevisionCommit summaryAuthorDate
r106360MFT r106347khorn19:52, 15 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100954Updated TwoStepAmount form to use ResourceLoader. Created ResourceModule gc.f...jpostlethwaite07:14, 27 October 2011
r101060Enabling javascript for the module: gc.form.core.validatejpostlethwaite21:30, 27 October 2011
r101554Added jqueryui accordian to module gc.form.core.validate. Added css to module...jpostlethwaite23:55, 1 November 2011

Status & tagging log