r105635 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105634‎ | r105635 | r105636 >
Date:01:40, 9 December 2011
Author:bsitu
Status:ok (Comments)
Tags:
Comment:
Send out email verification only if the user has email and the email has not been verified
Modified paths:
  • /trunk/extensions/MoodBar/ApiMoodBarSetUserEmail.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/ApiMoodBarSetUserEmail.php
——@@ -45,7 +45,7 @@
4646
4747 case 'resendverification':
4848 //only sends the email if the email has not been verified
49 - if ( $wgUser->getEmailAuthenticationTimestamp() === null ) {
 49+ if ( $wgUser->getEmail() && $wgUser->isEmailConfirmed() == false ) {
5050 $status = $wgUser->sendConfirmationMail( 'set' );
5151 if ( !$status->isGood() ) {
5252 $error = $status->getWikiText( 'mailerror' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r106348follow up to r105635 - use "!" instead of "== false" in condition checking fo...bsitu18:19, 15 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105385Add Moodbar type stat for feedbackdashboard page, MoodBarSetUserEmal API and ...bsitu23:52, 6 December 2011

Comments

#Comment by Catrope (talk | contribs)   21:18, 14 December 2011 
+				if ( $wgUser->getEmail() && $wgUser->isEmailConfirmed() == false ) {

== false ? Just use !$wgUser->isEmailConfirmed() .

Status & tagging log