r106246 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106245‎ | r106246 | r106247 >
Date:21:40, 14 December 2011
Author:kaldari
Status:resolved (Comments)
Tags:
Comment:
follow-up to r105965 - better condition statement
Modified paths:
  • /trunk/extensions/ContributionReporting/DailyTotal_body.php (modified) (history)
  • /trunk/extensions/ContributionReporting/FundraiserStatistics_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ContributionReporting/FundraiserStatistics_body.php
@@ -325,7 +325,7 @@
326326
327327 // Use database
328328 $dbr = efContributionReportingConnection();
329 - // Set timezone to UTC just in case
 329+ // Set timezone to UTC (contribution data will always be in UTC)
330330 date_default_timezone_set( 'UTC' );
331331
332332 $conditions = array(
Index: trunk/extensions/ContributionReporting/DailyTotal_body.php
@@ -118,7 +118,7 @@
119119 $result = $dbr->select(
120120 'public_reporting_days',
121121 'round( prd_total ) AS total',
122 - "prd_date = '$today'",
 122+ 'prd_date' => $today,
123123 __METHOD__
124124 );
125125 $row = $dbr->fetchRow( $result );

Follow-up revisions

RevisionCommit summaryAuthorDate
r106287follow-up to r106246 - fixing syntax errorskaldari00:24, 15 December 2011
r106696MFT r105145, r105454, r105641, r105657, r105659, r105757, r105916, r105965, r...awjrichards20:59, 19 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105965making sure nothing touches the public reporting table except the cron job, r...kaldari01:15, 13 December 2011

Comments

#Comment by Johnduhart (talk | contribs)   00:14, 15 December 2011
#Comment by Kaldari (talk | contribs)   00:24, 15 December 2011

Oops, fixed in r106287.

Status & tagging log