r106076 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106075‎ | r106076 | r106077 >
Date:20:10, 13 December 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Partly revert r106070 for now: Flooding of translatewiki.net log/channel:
PHP Notice: Use of User::getSkin was deprecated in MediaWiki 1.18. [Called from TalkpageView::show in /www/w/extensions/LiquidThreads/pages/TalkpageView.php at line 251] in /www/w/includes/GlobalFunctions.php on line 3520
PHP Notice: Use of User::getSkin was deprecated in MediaWiki 1.18. [Called from MessageTable::contents in /www/w/extensions/Translate/utils/MessageTable.php at line 98] in /www/w/includes/GlobalFunctions.php on line 3520
PHP Notice: Use of User::getSkin was deprecated in MediaWiki 1.18. [Called from TranslationHelpers::ajaxEditLink in /www/w/extensions/Translate/utils/TranslationHelpers.php at line 1186] in /www/w/includes/GlobalFunctions.php on line 3520
PHP Notice: Use of User::getSkin was deprecated in MediaWiki 1.18. [Called from ThreadPermalinkView::getSubtitle in /www/w/extensions/LiquidThreads/pages/ThreadPermalinkView.php at line 153] in /www/w/includes/GlobalFunctions.php on line 3520
and maybe more
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
——@@ -2594,7 +2594,7 @@
25952595 * @deprecated since 1.18 Use ->getSkin() in the most relevant outputting context you have
25962596 */
25972597 public function getSkin() {
2598 - wfDeprecated( __METHOD__, '1.18' );
 2598+ # wfDeprecated( __METHOD__, '1.18' ); // r106070 but still used in some extensions
25992599 return RequestContext::getMain()->getSkin();
26002600 }
26012601

Follow-up revisions

RevisionCommit summaryAuthorDate
r106174Self revert r106076 which was a revert of r106070.raymond11:50, 14 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106070added missing deprecation noticesjeroendedauw19:51, 13 December 2011

Comments

#Comment by Jeroen De Dauw (talk | contribs)   21:44, 13 December 2011

Fixed in both Translate and LQT

#Comment by Raymond (talk | contribs)   12:00, 14 December 2011

Still one (at least):

PHP Notice: Use of User::getSkin was deprecated in MediaWiki 1.18. [Called from SMQueryHandler::handleResultSubject in /www/w/extensions/SemanticMaps/includes/queryprinters/SM_QueryHandler.php at line 326] in /www/w/includes/GlobalFunctions.php on line 3520

Status & tagging log