r106174 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106173‎ | r106174 | r106175 >
Date:11:50, 14 December 2011
Author:raymond
Status:reverted
Tags:
Comment:
Self revert r106076 which was a revert of r106070.
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -2594,7 +2594,7 @@
25952595 * @deprecated since 1.18 Use ->getSkin() in the most relevant outputting context you have
25962596 */
25972597 public function getSkin() {
2598 - # wfDeprecated( __METHOD__, '1.18' ); // r106070 but still used in some extensions
 2598+ wfDeprecated( __METHOD__, '1.18' );
25992599 return RequestContext::getMain()->getSkin();
26002600 }
26012601

Follow-up revisions

RevisionCommit summaryAuthorDate
r106187Comment out wfDeprecated() call in User::getSkin(), there's over 300 uses in ...hashar13:00, 14 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106070added missing deprecation noticesjeroendedauw19:51, 13 December 2011
r106076Partly revert r106070 for now: Flooding of translatewiki.net log/channel:...raymond20:10, 13 December 2011

Status & tagging log