r105892 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105891‎ | r105892 | r105893 >
Date:15:36, 12 December 2011
Author:yonishostak
Status:resolved (Comments)
Tags:
Comment:
AFTv5: added IE-specific module
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.js (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css
___________________________________________________________________
Added: svn:eol-style
11 + native
Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.js
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.js
___________________________________________________________________
Added: svn:eol-style
22 + native
Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
@@ -73,6 +73,7 @@
7474 mw.config.get( 'wgArticleFeedbackv5LinkBuckets' )
7575 );
7676 var nameMap = { '-': '0', 'A': '1', 'B': '2', 'C': '3' };
 77+ aft5_debug('Links option: ' + bucketName + ' - ' + nameMap[bucketName]);
7778 return nameMap[bucketName];
7879 }
7980 }();
Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js
@@ -77,6 +77,10 @@
7878 // Lazy loading
7979 if ( !disable && ( wonLottery || enable ) ) {
8080 mw.loader.load( 'ext.articleFeedbackv5' );
 81+ // Load the IE-specific module
 82+ if( navigator.appVersion.indexOf(�MSIE�) != -1 ) {
 83+ mw.loader.load( 'ext.articleFeedbackv5.ie' );
 84+ }
8185 }
8286 }
8387 } );
Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -34,6 +34,10 @@
3535 'ext.articleFeedbackv5.ratingi18n',
3636 ),
3737 ),
 38+ 'ext.articleFeedbackv5.ie' => array(
 39+ 'scripts' => 'ext.articleFeedbackv5/ext.articleFeedbackv5.ie.js',
 40+ 'styles' => 'ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css'
 41+ ),
3842 'ext.articleFeedbackv5.ratingi18n' => array(
3943 'messages' => null, // Filled in by the resourceLoaderRegisterModules() hook function later
4044 ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r105893AFTv5: code-style fixyonishostak15:37, 12 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   15:38, 12 December 2011

Encoding looks broken.

Status & tagging log