r105891 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105890‎ | r105891 | r105892 >
Date:15:31, 12 December 2011
Author:hashar
Status:resolved (Comments)
Tags:
Comment:
add some namespaces equality tests

Follow up 103893
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/MWNamespaceTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/MWNamespaceTest.php
@@ -191,8 +191,19 @@
192192 $this->assertTrue( MWNamespace::subjectEquals( NS_MAIN, NS_TALK ) );
193193 $this->assertTrue( MWNamespace::subjectEquals( NS_USER, NS_USER_TALK ) );
194194 $this->assertFalse( MWNamespace::subjectEquals( NS_PROJECT, NS_TEMPLATE ) );
 195+ $this->assertFalse( MWNamespace::subjectEquals( NS_SPECIAL, NS_MAIN ) );
195196 }
196197
 198+ public function testSpecialAndMediaAreDifferentSubjects() {
 199+ $this->assertFalse( MWNamespace::subjectEquals(
 200+ NS_MEDIA, NS_SPECIAL
 201+ ), "NS_MEDIA and NS_SPECIAL are different subhects" );
 202+ $this->assertFalse( MWNamespace::subjectEquals(
 203+ NS_SPECIAL, NS_MEDIA
 204+ ), "NS_SPECIAL and NS_MEDIA are different subhects" );
 205+
 206+ }
 207+
197208 /**
198209 * @todo Implement testGetCanonicalNamespaces().
199210 */

Follow-up revisions

RevisionCommit summaryAuthorDate
r105896fix typo in message...hashar15:47, 12 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103893Implement a number of namespace related equals functions:...dantman13:34, 22 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   15:37, 12 December 2011

subhects -> subjects or even subject namespaces

#Comment by Hashar (talk | contribs)   15:47, 12 December 2011

typo fixed with r105896

Status & tagging log