r105796 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105795‎ | r105796 | r105797 >
Date:13:54, 11 December 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Per Platonides, fix for r100445: make sure user's language is English so that it doesn't break test
Modified paths:
  • /trunk/phase3/tests/phpunit/skins/SideBarTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/skins/SideBarTest.php
——@@ -37,6 +37,7 @@
3838 parent::setUp();
3939 $this->initMessagesHref();
4040 $this->skin = new SkinTemplate();
 41+ $this->skin->getContext()->setLang( Language::factory( 'en' ) );
4142 }
4243 function tearDown() {
4344 parent::tearDown();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100445Use local context to get messagesialex20:09, 21 October 2011

Comments

#Comment by Platonides (talk | contribs)   16:30, 11 December 2011

I would have prefered a more gneneral solution (this is likely to happen in more cases), but fixes the actual problem.

Status & tagging log