r105795 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105794‎ | r105795 | r105796 >
Date:13:29, 11 December 2011
Author:ialex
Status:ok
Tags:
Comment:
Follow-up r105790: make tests work again
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/ArticleTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/ArticleTest.php
@@ -19,8 +19,8 @@
2020
2121 }
2222
23 - function testImplementsGetMagic() {
24 - $this->assertEquals( -1, $this->article->mCounter, "Article __get magic" );
 23+ function testImplementsGetMagic() {
 24+ $this->assertEquals( false, $this->article->mLatest, "Article __get magic" );
2525 }
2626
2727 /**
@@ -28,16 +28,16 @@
2929 */
3030 function testImplementsSetMagic() {
3131
32 - $this->article->mCounter = 2;
33 - $this->assertEquals( 2, $this->article->mCounter, "Article __set magic" );
 32+ $this->article->mLatest = 2;
 33+ $this->assertEquals( 2, $this->article->mLatest, "Article __set magic" );
3434 }
3535
3636 /**
3737 * @depends testImplementsSetMagic
3838 */
3939 function testImplementsCallMagic() {
40 - $this->article->mCounter = 33;
41 - $this->assertEquals( 33, $this->article->getCount(), "Article __call magic" );
 40+ $this->article->mLatest = 33;
 41+ $this->assertEquals( 33, $this->article->getLatest(), "Article __call magic" );
4242 }
4343
4444 function testGetOrSetOnNewProperty() {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105790Moved view count from WikiPage to Title; avoids an extra DB query when showin...ialex11:30, 11 December 2011

Status & tagging log