r105569 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105568‎ | r105569 | r105570 >
Date:18:07, 8 December 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fix version check version from r105559
Modified paths:
  • /trunk/phase3/includes/Sanitizer.php (modified) (history)
  • /trunk/phase3/includes/media/Bitmap.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Sanitizer.php
@@ -457,10 +457,14 @@
458458 # and see if we find a match below them
459459 $optstack = array();
460460 array_push( $optstack, $ot );
461 - $ot = @array_pop( $tagstack );
 461+ wfSuppressWarnings();
 462+ $ot = array_pop( $tagstack );
 463+ wfRestoreWarnings();
462464 while ( $ot != $t && isset( $htmlsingleallowed[$ot] ) ) {
463465 array_push( $optstack, $ot );
464 - $ot = @array_pop( $tagstack );
 466+ wfSuppressWarnings();
 467+ $ot = array_pop( $tagstack );
 468+ wfRestoreWarnings();
465469 }
466470 if ( $t != $ot ) {
467471 # No match. Push the optional elements back again
Index: trunk/phase3/includes/media/Bitmap.php
@@ -279,7 +279,7 @@
280280 < $wgSharpenReductionThreshold ) {
281281 $sharpen = "-sharpen " . wfEscapeShellArg( $wgSharpenParameter );
282282 }
283 - if ( version_compare( $this->getMagickVersion(), "6.3.5" ) >= 0 ) {
 283+ if ( version_compare( $this->getMagickVersion(), "6.5.6" ) >= 0 ) {
284284 // JPEG decoder hint to reduce memory, available since IM 6.5.6-2
285285 $decoderHint = "-define jpeg:size={$params['physicalDimensions']}";
286286 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105559Bug 32874 - Bitmap.php uses -define in ImageMagick configuration line which r...reedy16:18, 8 December 2011

Comments

#Comment by Reedy (talk | contribs)   18:09, 8 December 2011

Sanitizer changes unrelated, but are ok, removing usages of @ as an error suppression operator

Status & tagging log