r105568 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105567‎ | r105568 | r105569 >
Date:18:00, 8 December 2011
Author:jeroendedauw
Status:reverted
Tags:
Comment:
Follow up to r105567;
Modified paths:
  • /trunk/extensions/Reviews/Reviews.hooks.php (modified) (history)
  • /trunk/extensions/Reviews/Reviews.i18n.php (modified) (history)
  • /trunk/extensions/Reviews/includes/ReviewControl.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Reviews/includes/ReviewControl.php
@@ -46,7 +46,7 @@
4747 }
4848
4949 $attribs['data-review'] = FormatJson::encode( $review );
50 - $attribs['data-reload-target'] = $context->getTitle()->getLocalURL() . '#reviewslist';
 50+ $attribs['data-reload-target'] = $context->getTitle()->getLocalURL( array( 'action' => 'refresh' ) );
5151
5252 $out->addHTML( Html::element( 'div', $attribs ) );
5353 }
Index: trunk/extensions/Reviews/Reviews.i18n.php
@@ -22,6 +22,7 @@
2323
2424 // Misc
2525 'reviews-toplink' => 'My reviews',
 26+ 'reviews-list-title' => 'Reviews',
2627
2728 // Rights
2829 'right-reviewsadmin' => 'Manage reviews',
Index: trunk/extensions/Reviews/Reviews.hooks.php
@@ -172,15 +172,14 @@
173173 $reviewPager = new ReviewPager( array( 'page_id' => $out->getTitle()->getArticleID() ) );
174174
175175 if ( $reviewPager->getNumRows() ) {
 176+ $out->addHTML( HTML::element( 'h2', array( 'id' => 'reviewslist' ), wfMsg( 'reviews-list-title' ) ) );
 177+
176178 $out->addHTML(
177179 $reviewPager->getNavigationBar() .
178180 $reviewPager->getBody() .
179181 $reviewPager->getNavigationBar()
180182 );
181183 }
182 - else {
183 - $this->getOutput()->addWikiMsg( 'reviews-pager-no-results' );
184 - }
185184
186185 /* User */ $user = $out->getUser();
187186

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105567layout tweaks and cleanupjeroendedauw17:50, 8 December 2011

Status & tagging log