r105428 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105427‎ | r105428 | r105429 >
Date:14:25, 7 December 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
(bug 32473) [[Special:PasswordReset]] can not be used on private wiki

This patch is a quick fix for REL1_18 branch.

For later:
We should not have hack in Title.php to allow some specific special pages
this should be made possible using SpecialPage. Would make code cleaner.
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
——@@ -1669,7 +1669,10 @@
16701670
16711671 # Always grant access to the login page.
16721672 # Even anons need to be able to log in.
1673 - if ( $this->isSpecial( 'Userlogin' ) || $this->isSpecial( 'ChangePassword' ) ) {
 1673+ if ( $this->isSpecial( 'Userlogin' )
 1674+ || $this->isSpecial( 'ChangePassword' )
 1675+ || $this->isSpecial( 'PasswordReset' )
 1676+ ) {
16741677 return $errors;
16751678 }
16761679

Follow-up revisions

RevisionCommit summaryAuthorDate
r105537MFT to REL1_18 r105428...hashar11:06, 8 December 2011
r106275MFT r105428: Special:PasswordReset can not be used on a private wikitstarling23:01, 14 December 2011

Comments

#Comment by Hashar (talk | contribs)   14:28, 7 December 2011

Need backport (and release note) for REL1_18.

WMF needs that since we have a few private wikis.

Please note this patch does not refactor anything so we can get included easily in REL1_18.

#Comment by Bryan (talk | contribs)   14:40, 7 December 2011

The nice solution would probably be a new function SpecialPage::isAlwaysReadable();

Status & tagging log