r105429 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105428‎ | r105429 | r105430 >
Date:14:28, 7 December 2011
Author:santhosh
Status:ok
Tags:
Comment:
CSS cleanup,
Dont wait, just show the menu without animation
And some spaces.
Follow up r105286
Modified paths:
  • /trunk/extensions/WebFonts/resources/ext.webfonts.css (modified) (history)
  • /trunk/extensions/WebFonts/resources/ext.webfonts.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.js
@@ -333,15 +333,15 @@
334334 // If RTL, add to the right of top personal links. Else, to the left
335335 var fn = $( 'body' ).hasClass( 'rtl' ) ? 'append' : 'prepend';
336336 $( '#p-personal ul:first' )[fn]( $li );
337 - $( 'body').prepend($menu);
 337+ $( 'body' ).prepend( $menu );
338338 $menu.hide();
339339 $li.hover( function() {
340340 $menuItemsDiv.css( 'left', $li.offset().left );
341 - $menu.slideDown( 'slow' );
 341+ $menu.show();
342342 });
343343 $menu.hover( function() {
344344 }, function() {
345 - $menu.slideUp( 'slow' );
 345+ $menu.hide();
346346 });
347347 // Workaround for IE bug - ActiveX components like input fields coming on top of everything.
348348 // @todo Is there a better solution other than hiding it on hover?
Index: trunk/extensions/WebFonts/resources/ext.webfonts.css
@@ -46,7 +46,6 @@
4747 text-align: left;
4848 top: 20px;
4949 width: 300px;
50 - font-size: 0.8em;
5150 }
5251
5352 /* OVERRIDDEN BY COMPLIANT BROWSERS */
@@ -82,18 +81,9 @@
8382 margin: 0;
8483 margin-left: -1px;
8584 text-align: left;
 85+ font-size: 0.8em;
8686 }
87 -/* Fixes old versions of FireFox */
88 -div.webfontMenu ul,
89 -x:-moz-any-link {
90 - min-width: 5em;
91 -}
92 -/* Returns things back to normal in modern versions of FireFox */
93 -div.webfontMenu ul,
94 -x:-moz-any-link,
95 -x:default {
96 - min-width: 0;
97 -}
 87+
9888 div.webfontMenu li {
9989 padding: 0;
10090 margin: 0;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105286Removed the monobook skin specific code added in r105181....santhosh11:19, 6 December 2011

Status & tagging log