r105348 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105347‎ | r105348 | r105349 >
Date:20:49, 6 December 2011
Author:reedy
Status:deferred
Tags:
Comment:
Add $caAddUserToCrowd global
Modified paths:
  • /trunk/extensions/CrowdAuthentication/CrowdAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CrowdAuthentication/CrowdAuthentication.php
@@ -27,6 +27,7 @@
2828 'path' => __FILE__,
2929 'name' => 'Crowd Authentication Plugin',
3030 'author' => 'River Tarnell',
 31+ 'version' => '1.1',
3132 'descriptionmsg' => 'crowdauthentication-desc',
3233 'url' => 'http://www.mediawiki.org/wiki/Extension:CrowdAuthentication'
3334 );
@@ -40,6 +41,8 @@
4142 $caImportGroups = true;
4243 $caOverwriteLocalGroups = false;
4344
 45+$caAddUserToCrowd = true;
 46+
4447 class caPasswordCredential {
4548 /**
4649 * @var string
@@ -307,6 +310,11 @@
308311 * @return bool
309312 */
310313 public function addUser( $user, $password, $email = '', $realname = '' ) {
 314+ global $caAddUserToCrowd;
 315+ if ( !$caAddUserToCrowd ) {
 316+ return true;
 317+ }
 318+
311319 global $caDefaultGroups;
312320 $crowd = $this->getCrowd();
313321 $nameparts = split( " ", $realname, 2 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r105355Comment out the changes I made in r105348, it seems the TS has some upstream ...reedy21:24, 6 December 2011

Status & tagging log