r105347 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105346‎ | r105347 | r105348 >
Date:20:42, 6 December 2011
Author:reedy
Status:deferred
Tags:
Comment:
register_globals issues? Seriously?
Modified paths:
  • /trunk/extensions/CrowdAuthentication/CrowdAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CrowdAuthentication/CrowdAuthentication.php
@@ -33,6 +33,13 @@
3434
3535 $wgExtensionMessagesFiles['CrowdAuthentication'] = dirname( __FILE__ ) . '/CrowdAuthentication.i18n.php';
3636
 37+$caApplicationName = 'mediawiki';
 38+$caApplicationPassword = '';
 39+$caCrowdServerUrl = 'http://localhost:8095/crowd/services';
 40+$caDefaultGroups = array("jira-users", "confluence-users");
 41+$caImportGroups = true;
 42+$caOverwriteLocalGroups = false;
 43+
3744 class caPasswordCredential {
3845 /**
3946 * @var string
@@ -331,8 +338,10 @@
332339
333340 try {
334341 $crowd->addPrincipal( array( "in0" => $this->token,
335 - "in1" => $principal,
336 - "in2" => $cred ) );
 342+ "in1" => $principal,
 343+ "in2" => $cred
 344+ )
 345+ );
337346 foreach ( $caDefaultGroups as $group ) {
338347 $crowd->addPrincipalToGroup( array( "in0" => $this->token, "in1" => $user->getName(), "in2" => $group ) );
339348 }

Status & tagging log