r105194 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105193‎ | r105194 | r105195 >
Date:17:34, 5 December 2011
Author:rsterbin
Status:resolved
Tags:
Comment:
Fixed self-closing span tags, as per Roan's review
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
@@ -75,7 +75,7 @@
7676
7777 /* Add section links */
7878 if ( '1' == linkBucket ) {
79 - var $wrp = $( '<span class="articleFeedbackv5-sectionlink-wrap"/>' )
 79+ var $wrp = $( '<span class="articleFeedbackv5-sectionlink-wrap"></span>' )
8080 .html( '&nbsp;[<a href="#mw-articlefeedbackv5" class="articleFeedbackv5-sectionlink"></a>]' );
8181 $wrp.find( 'a.articleFeedbackv5-sectionlink' )
8282 .data( 'linkId', 1 )
@@ -90,7 +90,7 @@
9191
9292 /* Add titlebar link */
9393 if ( '2' == linkBucket ) {
94 - var $tlk = $( '<a href="#mw-articleFeedbackv5" id="articleFeedbackv5-titlebarlink" />' )
 94+ var $tlk = $( '<a href="#mw-articleFeedbackv5" id="articleFeedbackv5-titlebarlink"></span>' )
9595 .data( 'linkId', 2 )
9696 .text( mw.msg( 'articlefeedbackv5-titlebar-linktext' ) )
9797 .click( function ( e ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r105881Followup r105194: <a> tags have to be closed with </a>, not with </span>catrope14:57, 12 December 2011

Status & tagging log