r105881 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105880‎ | r105881 | r105882 >
Date:14:57, 12 December 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r105194: <a> tags have to be closed with </a>, not with </span>
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
——@@ -97,7 +97,7 @@
9898
9999 /* Add titlebar link */
100100 if ( '2' == linkBucket ) {
101 - var $tlk = $( '<a href="#mw-articleFeedbackv5" id="articleFeedbackv5-titlebarlink"></span>' )
 101+ var $tlk = $( '<a href="#mw-articleFeedbackv5" id="articleFeedbackv5-titlebarlink"></a>' )
102102 .data( 'linkId', 2 )
103103 .text( mw.msg( 'articlefeedbackv5-titlebar-linktext' ) )
104104 .click( function ( e ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105194Fixed self-closing span tags, as per Roan's reviewrsterbin17:34, 5 December 2011

Status & tagging log