r105140 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105139‎ | r105140 | r105141 >
Date:23:34, 4 December 2011
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Added file old version name sanity check to recordUpload2()
Modified paths:
  • /trunk/phase3/includes/filerepo/file/LocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/file/LocalFile.php
——@@ -1007,6 +1007,9 @@
10081008 );
10091009
10101010 if ( $dbw->affectedRows() == 0 ) {
 1011+ if ( $oldver == '' ) {
 1012+ throw new MWException( "Empty oi_archive_name. Database and storage out of sync?" );
 1013+ }
10111014 $reupload = true;
10121015
10131016 # Collision, this is an update of a file

Follow-up revisions

RevisionCommit summaryAuthorDate
r105153Revert r105140 temporarily. The exception is thrown while running the parser ...catrope07:03, 5 December 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   23:40, 4 December 2011

This exposes a NewParserTests bug I ran into in branch.

Status & tagging log