r105153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105152‎ | r105153 | r105154 >
Date:07:03, 5 December 2011
Author:catrope
Status:ok
Tags:
Comment:
Revert r105140 temporarily. The exception is thrown while running the parser tests (at least from Jenkins, haven't tried locally), which completely breaks the test suite and renders Jenkins useless. Feel free to reapply once the cause of the oi_archive_name bug is fixed and committing this won't cause exceptions to be thrown in Jenkins's face.
Modified paths:
  • /trunk/phase3/includes/filerepo/file/LocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/file/LocalFile.php
——@@ -1007,9 +1007,6 @@
10081008 );
10091009
10101010 if ( $dbw->affectedRows() == 0 ) {
1011 - if ( $oldver == '' ) {
1012 - throw new MWException( "Empty oi_archive_name. Database and storage out of sync?" );
1013 - }
10141011 $reupload = true;
10151012
10161013 # Collision, this is an update of a file

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105140Added file old version name sanity check to recordUpload2()aaron23:34, 4 December 2011

Status & tagging log