r105057 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105056‎ | r105057 | r105058 >
Date:04:34, 3 December 2011
Author:rsterbin
Status:deferred
Tags:
Comment:
Repeat bug fix for the infinitely disable expertise box (r105031 apparently nuked that one, too); also fixed some stray uses of .find
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -707,8 +707,8 @@
708708 */
709709 getFormData: function () {
710710 var data = {};
711 - data.tag = $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-tags input[checked]' ).val();
712 - data.comment = $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-comment textarea' ).val();
 711+ data.tag = $.articleFeedbackv5.find( '.articleFeedbackv5-tags input[checked]' ).val();
 712+ data.comment = $.articleFeedbackv5.find( '.articleFeedbackv5-comment textarea' ).val();
713713 for ( t in $.articleFeedbackv5.currentBucket().commentDefault ) {
714714 if ( data.comment == $.articleFeedbackv5.currentBucket().commentDefault[t] ) {
715715 data.comment = '';
@@ -998,8 +998,8 @@
999999 */
10001000 getFormData: function () {
10011001 var data = {};
1002 - data.rating = $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-rating input:hidden' ).val();
1003 - data.comment = $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-comment textarea' ).val();
 1002+ data.rating = $.articleFeedbackv5.find( '.articleFeedbackv5-rating input:hidden' ).val();
 1003+ data.comment = $.articleFeedbackv5.find( '.articleFeedbackv5-comment textarea' ).val();
10041004 if ( data.comment == mw.msg( 'articlefeedbackv5-bucket3-comment-default' ) ) {
10051005 data.comment = '';
10061006 }
@@ -1374,7 +1374,7 @@
13751375 // Slide-down for the expertise checkboxes
13761376 $block.find( '.articleFeedbackv5-expertise > input:checkbox' )
13771377 .change( function () {
1378 - var $options = $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-expertise-options' );
 1378+ var $options = $.articleFeedbackv5.find( '.articleFeedbackv5-expertise-options' );
13791379 if ( $(this).is( ':checked' ) ) {
13801380 $options.slideDown( 'fast' );
13811381 } else {
@@ -1453,7 +1453,7 @@
14541454 });
14551455 rlabel.mousedown( function () {
14561456 $.articleFeedbackv5.enableSubmission( true );
1457 - var $ui = $.articleFeedbackv5.find( 'articleFeedbackv5-ui' );
 1457+ var $ui = $.articleFeedbackv5.find( '.articleFeedbackv5-ui' );
14581458 if ( $ui.hasClass( 'articleFeedbackv5-expired' ) ) {
14591459 // Changing one means the rest will get submitted too
14601460 $ui.removeClass( 'articleFeedbackv5-expired' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105031Confirmation/call to actionseanheavey00:36, 3 December 2011

Status & tagging log