r105031 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105030‎ | r105031 | r105032 >
Date:00:36, 3 December 2011
Author:seanheavey
Status:deferred
Tags:
Comment:
Confirmation/call to action
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -525,7 +525,7 @@
526526
527527 .articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder {
528528 display: inline-block;
529 - height: 19px;
 529+ height: 22px;
530530 line-height: 22px;
531531 font-size: .9em;
532532 min-width: 34px;
@@ -586,7 +586,7 @@
587587 .articleFeedbackv5-ui .articleFeedbackv5-submit,
588588 .articleFeedbackv5-ui .articleFeedbackv5-edit-cta-link {
589589 float: left;
590 - height: 29px;
 590+ height: 35px !important;
591591 width: auto;
592592 text-align: center;
593593 padding: 0 6px;
@@ -616,7 +616,7 @@
617617 color: #fff;
618618 /*text-shadow: 1px 1px 1px #000;*/
619619 padding: 1px 30px 0 0;
620 - margin: 5px 0 0;
 620+ margin: 8px 0 0;
621621 background: url(images/bg-submit-icon.png) right center no-repeat;
622622 }
623623
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -147,6 +147,7 @@
148148 <div class="articleFeedbackv5-buffer">\
149149 <div class="articleFeedbackv5-title-wrap">\
150150 <h2 class="articleFeedbackv5-title"></h2>\
 151+ <div class="clear"></div>\
151152 </div>\
152153 <div class="articleFeedbackv5-ui" />\
153154 </div>\
@@ -1331,7 +1332,7 @@
13321333 // Slide-down for the expertise checkboxes
13331334 $block.find( '.articleFeedbackv5-expertise > input:checkbox' )
13341335 .change( function () {
1335 - var $options = $.articleFeedbackv5.find( '.articleFeedbackv5-expertise-options' );
 1336+ var $options = $.articleFeedbackv5.$holder.find( '.articleFeedbackv5-expertise-options' );
13361337 if ( $(this).is( ':checked' ) ) {
13371338 $options.slideDown( 'fast' );
13381339 } else {
@@ -1410,7 +1411,7 @@
14111412 });
14121413 rlabel.mousedown( function () {
14131414 $.articleFeedbackv5.enableSubmission( true );
1414 - var $ui = $.articleFeedbackv5.find( '.articleFeedbackv5-ui' );
 1415+ var $ui = $.articleFeedbackv5.find( 'articleFeedbackv5-ui' );
14151416 if ( $ui.hasClass( 'articleFeedbackv5-expired' ) ) {
14161417 // Changing one means the rest will get submitted too
14171418 $ui.removeClass( 'articleFeedbackv5-expired' );
@@ -1623,9 +1624,6 @@
16241625 $.articleFeedbackv5.find( '.articleFeedbackv5-expertise input:checked' ).each( function () {
16251626 data['expertise-' + $( this ).val()] = 1;
16261627 } );
1627 - if ( $.articleFeedbackv5.find( '.articleFeedbackv5-helpimprove input:checked' ).length > 0 ) {
1628 - data.email = $.articleFeedbackv5.find( '.articleFeedbackv5-helpimprove-email' ).val();
1629 - }
16301628 return data;
16311629 },
16321630
@@ -1791,7 +1789,7 @@
17921790 * The template for the whole block
17931791 */
17941792 block: '\
1795 - <div class="articleFeedbackv5-confirmation-panel>\
 1793+ <div class="articleFeedbackv5-confirmation-panel">\
17961794 <div class="articleFeedbackv5-panel-leftContent">\
17971795 <div class="articleFeedbackv5-confirmation-text">\
17981796 <span class=articleFeedbackv5-confirmation-thanks">[Thanks!]</span><span class="articleFeedbackv5-confirmation-follow-up">[Your feedback has been saved.]</span>\

Follow-up revisions

RevisionCommit summaryAuthorDate
r105054Cleaned up form validation display:...rsterbin03:57, 3 December 2011
r105057Repeat bug fix for the infinitely disable expertise box (r105031 apparently n...rsterbin04:34, 3 December 2011

Status & tagging log