r105056 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105055‎ | r105056 | r105057 >
Date:04:29, 3 December 2011
Author:aaron
Status:ok
Tags:
Comment:
Remove use of obsolete aliases global
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.setup.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/ConfirmAccount.setup.php
@@ -9,12 +9,9 @@
1010 *
1111 * @param $classes Array $classes
1212 * @param $messagesFiles Array $messagesFiles
13 - * @param $aliasesFiles Array $aliasesFiles
1413 * @return void
1514 */
16 - public static function defineSourcePaths(
17 - array &$classes, array &$messagesFiles, array &$aliasesFiles
18 - ) {
 15+ public static function defineSourcePaths( array &$classes, array &$messagesFiles ) {
1916 $dir = dirname( __FILE__ );
2017
2118 # Basic directory layout
@@ -28,7 +25,7 @@
2926
3027 # Main i18n file and special page alias file
3128 $messagesFiles['ConfirmAccount'] = "$langDir/ConfirmAccount.i18n.php";
32 - $aliasesFiles['ConfirmAccount'] = "$langDir/ConfirmAccount.alias.php";
 29+ $messagesFiles['ConfirmAccountAliases'] = "$langDir/ConfirmAccount.alias.php";
3330
3431 # UI setup class
3532 $classes['ConfirmAccountUISetup'] = "$frontendDir/ConfirmAccountUI.setup.php";
Index: trunk/extensions/ConfirmAccount/ConfirmAccount.php
@@ -36,11 +36,7 @@
3737
3838 # Define were PHP files and i18n files are located
3939 require( dirname( __FILE__ ) . '/ConfirmAccount.setup.php' );
40 -ConfirmAccountSetup::defineSourcePaths(
41 - $wgAutoloadClasses,
42 - $wgExtensionMessagesFiles,
43 - $wgExtensionAliasesFiles
44 -);
 40+ConfirmAccountSetup::defineSourcePaths( $wgAutoloadClasses, $wgExtensionMessagesFiles );
4541
4642 # Define JS/CSS modules and file locations
4743 ConfirmAccountUISetup::defineResourceModules( $wgResourceModules );
@@ -79,7 +75,7 @@
8076 # This extension needs email enabled!
8177 # Otherwise users can't get their passwords...
8278 if ( !$wgEnableEmail ) {
83 - echo "ConfirmAccount extension requires \$wgEnableEmail set to true \n";
 79+ echo "ConfirmAccount extension requires \$wgEnableEmail set to true.\n";
8480 exit( 1 ) ;
8581 }
8682 }

Status & tagging log