r104592 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104591‎ | r104592 | r104593 >
Date:21:07, 29 November 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Change number separator from dot to a space, per User:Nemo_bis (it is the convention in Italian to use spaces)
Modified paths:
  • /trunk/phase3/languages/messages/MessagesIt.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesIt.php
——@@ -82,7 +82,7 @@
8383 'Discussioni_immagine' => NS_FILE_TALK,
8484 );
8585
86 -$separatorTransformTable = array( ',' => '.', '.' => ',' );
 86+$separatorTransformTable = array( ',' => "\xc2\xa0", '.' => ',' );
8787
8888 $dateFormats = array(
8989 'mdy time' => 'H:i',

Follow-up revisions

RevisionCommit summaryAuthorDate
r105202MFT r99905 r100958 r101995 r103128 r103168 r103173 r103646 r103802 r103804 r1...nikerabbit18:38, 5 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:34, 2 December 2011

I will forward all complains to Nemo_bis then.

#Comment by Brownout (talk | contribs)   21:34, 6 December 2011

This was a controversial change, currently discussed on a single wiki, and potentially it broke every Mediawiki installation. Please don't believe everything you're told about language conventions by a single user.

#Comment by Nemo bis (talk | contribs)   22:00, 6 December 2011

Complaints taken. ;-) The formatnum is not under discussion and has been policy for years (beside being mandatory for the International System and some laws); no new errors have been reported so far (the example is a malformed expression, cf. https://it.wikipedia.org/?oldid=45460677 ).

#Comment by Brownout (talk | contribs)   22:07, 6 December 2011

No errors uh?

While we're at it, since it "has been policy for years", why was it changed now?

Status & tagging log