r101995 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101994‎ | r101995 | r101996 >
Date:14:50, 4 November 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Fix bug 31999 - having '' as option value didn't place nice with query parameters, where it was discarded at some point.
Modified paths:
  • /trunk/extensions/Translate/RcFilter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/RcFilter.php
@@ -15,7 +15,7 @@
1616 */
1717 class TranslateRcFilter {
1818 /**
19 - * Default action for the filter: ('', 'only', 'filter', 'site')
 19+ * Default action for the filter: ('noaction', 'only', 'filter', 'site')
2020 */
2121 protected static $defaultAction = 'filter';
2222
@@ -74,7 +74,7 @@
7575
7676 $label = Xml::label( wfMsg( 'translate-rc-translation-filter' ), 'mw-translation-filter' );
7777 $select = new XmlSelect( 'translations', 'mw-translation-filter', $default );
78 - $select->addOption( wfMsg( 'translate-rc-translation-filter-no' ), '' );
 78+ $select->addOption( wfMsg( 'translate-rc-translation-filter-no' ), 'noaction' );
7979 $select->addOption( wfMsg( 'translate-rc-translation-filter-only' ), 'only' );
8080 $select->addOption( wfMsg( 'translate-rc-translation-filter-filter' ), 'filter' );
8181 $select->addOption( wfMsg( 'translate-rc-translation-filter-site' ), 'site' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r105202MFT r99905 r100958 r101995 r103128 r103168 r103173 r103646 r103802 r103804 r1...nikerabbit18:38, 5 December 2011

Status & tagging log