r104424 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104423‎ | r104424 | r104425 >
Date:13:42, 28 November 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Spaces to tabs
Modified paths:
  • /trunk/extensions/ContributionReporting/ContributionReporting.php (modified) (history)
  • /trunk/extensions/ContributionReporting/FundraiserStatistics.css (modified) (history)
  • /trunk/extensions/ContributionReporting/modules (added) (history)

Diff [purge]

Index: trunk/extensions/ContributionReporting/ContributionReporting.php
@@ -57,8 +57,6 @@
5858 $wgSpecialPageGroups['FundraiserStatistics'] = 'contribution';
5959 $wgSpecialPageGroups['ContributionTrackingStatistics'] = 'contribution';
6060
61 -
62 -
6361 // Shortcut to this extension directory
6462 $dir = dirname( __FILE__ ) . '/';
6563
@@ -110,7 +108,6 @@
111109 // Cache timeout for fundraiser statistics, in seconds
112110 $egFundraiserStatisticsCacheTimeout = 900; // 15 minutes
113111
114 -
115112 $wgContributionTrackingStatisticsViewWeeks = 3;
116113
117114 $wgHooks['ParserFirstCallInit'][] = 'efContributionReportingSetup';
@@ -185,7 +182,6 @@
186183 */
187184 function efContributionReportingTotal( $start, $fudgeFactor ) {
188185 $db = efContributionReportingConnection();
189 - #$db = wfGetDB( DB_MASTER );
190186
191187 $sql = 'SELECT ROUND( SUM(converted_amount) ) AS ttl FROM public_reporting';
192188
@@ -216,8 +212,9 @@
217213 $start = false;
218214
219215 foreach( $args as $arg ) {
220 - if ( strpos($arg,'=') === false )
 216+ if ( strpos($arg,'=') === false ) {
221217 continue;
 218+ }
222219
223220 list($key,$value) = explode( '=', trim($arg), 2 );
224221
Index: trunk/extensions/ContributionReporting/FundraiserStatistics.css
@@ -21,11 +21,11 @@
2222 cursor: pointer;
2323 }
2424 div#configtoggle a, div#configtoggle a:visited {
25 - background-image: url("arrow.png");
26 - background-position: 0px -3px;
27 - background-repeat: no-repeat;
28 - padding-left: 16px;
29 - outline: 0;
 25+ background-image: url("arrow.png");
 26+ background-position: 0px -3px;
 27+ background-repeat: no-repeat;
 28+ padding-left: 16px;
 29+ outline: 0;
3030 }
3131
3232 .fundraiserstats-view-box {

Follow-up revisions

RevisionCommit summaryAuthorDate
r104586MFT r104062, r104247, r104248, r104362, r104370, r104372, r104424, r104425, r...awjrichards20:22, 29 November 2011

Comments

#Comment by Reedy (talk | contribs)   13:42, 28 November 2011

Bah. Added new folder also

Status & tagging log