r104350 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104349‎ | r104350 | r104351 >
Date:17:31, 27 November 2011
Author:johnduhart
Status:ok
Tags:
Comment:
Followup r104318, sort the options in the limit dropdown
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlockList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlockList.php
——@@ -470,9 +470,10 @@
471471
472472 if ( !in_array( $value, $this->mParams['options'] ) ) {
473473 $this->mParams['options'][ $this->mParent->getLanguage()->formatNum( $value ) ] = intval($value);
 474+ asort( $this->mParams['options'] );
474475 }
475476
476477 return true;
477478 }
478479
479 -}
\ No newline at end of file
 480+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r104486MFT r104318, r104322, r104350reedy21:03, 28 November 2011
r104487MFT r104486, Merges r104318, r104322, r104350reedy21:05, 28 November 2011
r105341Followup r104350, r104318: only allow custom limits through if they're valid ...brion19:45, 6 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104318Bug 32603 - limit option is missing on Special:BlockList...johnduhart22:15, 26 November 2011

Status & tagging log